feat(ui): updates to dark mode logic #3740
Conversation
Pull Request Test Coverage Report for Build 9362246394Details
💛 - Coveralls |
| @@ -666,6 +669,8 @@ export default { | |||
| hideTopbar: false, | |||
| title: '', | |||
| messages: [], | |||
| systemDark: false, | |||
| mq_system_dark: null, | |||
There was a problem hiding this comment.
why don't use a watch for this instead?
There was a problem hiding this comment.
Also it's not clear to me what mq_system_dark is used for, you never re-assign it, I would instead use a let in beforeMount instead
There was a problem hiding this comment.
First time using Vue. Will re look at the logic here. Thanks for the notes.
There was a problem hiding this comment.
It's ok no worries I appreciate a lot your help 🙏🏼
| beforeUnmount() { | ||
| if (this.mq_system_dark !== null) { | ||
| this.mq_system_dark.removeEventListener( | ||
| 'change', | ||
| this.updateSystemDark, | ||
| ) | ||
| } | ||
| }, |
There was a problem hiding this comment.
this is a bit useless as the App will only be unmounted when the page is destroyed
|
I don't have time right now to work on this. |
|
@zackbcom No worries, keep it open for now will see if I can find some time to look at it :) |
Pull Request Test Coverage Report for Build 11250226051Details
💛 - Coveralls |
|
This pull-request is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this pull-request entirely you can add the no-stale label |
Changes
nullas system defined.TODO
Testing Artifacts